[PATCH] D154579: [InstCombine] Only perform one iteration

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 10:51:11 PDT 2023


aeubanks added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:369
 
+static InstCombinePass createInstCombinePass() {
+  // InstCombine passes in the optimization pipeline should not verify that
----------------
imo the `InstCombinePass` constructor should default to `no-verify-fixpoint`, but `parseInstCombineOptions` should by default set `verify-fixpoint`, since we typically call the `InstCombinePass` constructor from pass pipelines


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154579/new/

https://reviews.llvm.org/D154579



More information about the llvm-commits mailing list