[PATCH] D156113: [CodeGen] Store call frame size in MachineBasicBlock

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

In D156113#4539464 <https://reviews.llvm.org/D156113#4539464>, @arsenm wrote:

> In D156113#4539462 <https://reviews.llvm.org/D156113#4539462>, @phosek wrote:
>
>> The new test is failing on Windows, would it be possible to take a look and revert if needed?
>>
>>   Script:
>>   --
>>   : 'RUN: at line 2';   c:\b\s\w\ir\x\w\llvm_build\bin\llc.exe -march=arm -run-pass none -o - C:\b\s\w\ir\x\w\llvm-llvm-project\llvm\test\CodeGen\MIR\ARM\call-frame-size.mir | c:\b\s\w\ir\x\w\llvm_build\bin\filecheck.exe C:\b\s\w\ir\x\w\llvm-llvm-project\llvm\test\CodeGen\MIR\ARM\call-frame-size.mir
>>   --
>>   Exit Code: 1
>>   
>>   Command Output (stdout):
>>   --
>>   $ ":" "RUN: at line 2"
>>   $ "c:\b\s\w\ir\x\w\llvm_build\bin\llc.exe" "-march=arm" "-run-pass" "none" "-o" "-" "C:\b\s\w\ir\x\w\llvm-llvm-project\llvm\test\CodeGen\MIR\ARM\call-frame-size.mir"
>>   # command stderr:
>>   error: Function 'callframesize' uses ARM instructions, but the target does not support ARM mode execution.
>>   
>>   error: command failed with exit status: 1
>>   $ "c:\b\s\w\ir\x\w\llvm_build\bin\filecheck.exe" "C:\b\s\w\ir\x\w\llvm-llvm-project\llvm\test\CodeGen\MIR\ARM\call-frame-size.mir"
>>   
>>   --
>
> I assume this just needs s/march/mtriple

@phosek does that fix it for you?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156113/new/

https://reviews.llvm.org/D156113