[PATCH] D91353: [CodeGenPrepare] Match complex multiply pattern (WIP).

Nuno Lopes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 09:07:23 PDT 2023


nlopes added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:7440
+  Value *Vec0Op0 =
+      Builder.CreateInsertElement(UndefValue::get(VecTy), Op0R, 0ull);
+  Value *Vec0Op1 = Builder.CreateInsertElement(Vec0Op0, Op0I, 1ull);
----------------
please use poison instead of undef as placeholder whenever possible.
We are trying to get rid of undef. Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91353/new/

https://reviews.llvm.org/D91353



More information about the llvm-commits mailing list