[PATCH] D155865: [AMDGPU][GlobalISel] Update legalizer for G_ABS, G_SMIN, G_SMAX, G_UMIN, G_UMAX

Thu Jul 27 08:55:24 PDT 2023

Acim-Maravic added a comment.

In D155865#4520845 <https://reviews.llvm.org/D155865#4520845>, @arsenm wrote:

>> moreElementsVector does not support G_ABS
>
> This is easy to just fix?

Yes but we do not need it in this patch. Should I fix it here anyway?

================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:1214
     if (ST.hasVOP3PInsts()) {
       getActionDefinitionsBuilder({G_SMIN, G_SMAX, G_UMIN, G_UMAX, G_ABS})
         .legalFor({S32, S16, V2S16})
----------------
arsenm wrote:
> I don't think there is a v2i16 abs is there? Should these just be lowered?
v2i16 is legal because patch D155867 will handle it in  RegBankSelect.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155865/new/

https://reviews.llvm.org/D155865