[PATCH] D151165: [ThinLTO] Make the cache key independent of the module identifier paths

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 06:50:39 PDT 2023


nikic added a comment.

In D151165#4538667 <https://reviews.llvm.org/D151165#4538667>, @akyrtzi wrote:

> What about changing the code to sort using the module hash:
>
>      llvm::sort(ImportModulesVector,
>                 [](const ImportModule &Lhs, const ImportModule &Rhs) -> bool {
>   -               return Lhs.getId() < Rhs.getId();
>   +               return Lhs.getHash() < Rhs.getHash();
>                 });
>
> would that resolve your issue?

>From a cursory test that seems to work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151165/new/

https://reviews.llvm.org/D151165



More information about the llvm-commits mailing list