[PATCH] D156390: [SDAG][RISCV] Avoid expanding is-power-of-2 pattern on riscv32/64 with zbb
Luke Lau via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 27 05:26:50 PDT 2023
luke added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:17502
+ if (VT.isVector())
+ return isTypeLegal(VT) && Subtarget.hasStdExtZvbb();
+ return Subtarget.hasStdExtZbb() && (VT == MVT::i32 || VT == MVT::i64);
----------------
I think if we check that the operation is legal then we don’t need to check for zbb/zvbb, since it’s only legal with those extensions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156390/new/
https://reviews.llvm.org/D156390
More information about the llvm-commits
mailing list