[PATCH] D156395: [Reassociate][NFC] Update the header comment of Reassociate Pass
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 27 05:23:38 PDT 2023
nikic added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/Reassociate.cpp:18
+// (starting at rank(the last function argument) << 16), which effectively gives
+// values in deep loops higher rank than values not in loops.
//
----------------
I think this comment shouldn't mention exact rank numbers. The important thing to convey at this level is that the rank ordering is constants, followed by arguments, followed by RPO order of instructions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156395/new/
https://reviews.llvm.org/D156395
More information about the llvm-commits
mailing list