[PATCH] D156318: Local: fix debug output of replaceDominatedUsesWith()

[Ramkumar Ramachandra via Phabricator via llvm-commits]

artagnon updated this revision to Diff 544705.
artagnon added a comment.

Address review comments by @nikic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156318/new/

https://reviews.llvm.org/D156318

Files:
  llvm/lib/Transforms/Utils/Local.cpp
  llvm/test/Transforms/Util/local-dbg-print.ll


Index: llvm/test/Transforms/Util/local-dbg-print.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/Util/local-dbg-print.ll
@@ -0,0 +1,34 @@
+; REQUIRES: asserts
+; RUN: opt -passes=gvn -debug-only=local -disable-output 2>&1 < %s | FileCheck %s
+
+define void @replaceDominatedUsesWith_debug(ptr nocapture writeonly %a, i32 %beam) {
+; CHECK: Replace dominated use of 'i64 %indvars.iv' as   %0 = zext i32 %beam to i64 in   %1 = shl nuw nsw i64 %indvars.iv, 1
+entry:
+  %0 = zext i32 %beam to i64
+  br label %for.body
+
+for.cond.cleanup:                                 ; preds = %for.inc
+  ret void
+
+for.body:                                         ; preds = %entry, %for.inc
+  %indvars.iv = phi i64 [ 0, %entry ], [ %indvars.iv.next, %for.inc ]
+  %cmp1 = icmp eq i64 %indvars.iv, %0
+  br i1 %cmp1, label %if.then, label %if.else
+
+if.then:                                          ; preds = %for.body
+  %1 = shl nuw nsw i64 %indvars.iv, 1
+  %arrayidx = getelementptr inbounds i32, ptr %a, i64 %1
+  store i32 0, ptr %arrayidx, align 4
+  br label %for.inc
+
+if.else:                                          ; preds = %for.body
+  %2 = shl nuw nsw i64 %indvars.iv, 1
+  %arrayidx4 = getelementptr inbounds i32, ptr %a, i64 %2
+  store i32 1, ptr %arrayidx4, align 4
+  br label %for.inc
+
+for.inc:                                          ; preds = %if.then, %if.else
+  %indvars.iv.next = add nuw nsw i64 %indvars.iv, 1
+  %exitcond.not = icmp eq i64 %indvars.iv.next, 10000
+  br i1 %exitcond.not, label %for.cond.cleanup, label %for.body
+}
Index: llvm/lib/Transforms/Utils/Local.cpp
===================================================================
--- llvm/lib/Transforms/Utils/Local.cpp
+++ llvm/lib/Transforms/Utils/Local.cpp
@@ -2896,9 +2896,10 @@
   for (Use &U : llvm::make_early_inc_range(From->uses())) {
     if (!Dominates(Root, U))
       continue;
+    LLVM_DEBUG(dbgs() << "Replace dominated use of '";
+               From->printAsOperand(dbgs());
+               dbgs() << "' as " << *To << " in " << *U.getUser() << "\n");
     U.set(To);
-    LLVM_DEBUG(dbgs() << "Replace dominated use of '" << From->getName()
-                      << "' as " << *To << " in " << *U << "\n");
     ++Count;
   }
   return Count;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156318.544705.patch
Type: text/x-patch
Size: 2313 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230727/16b0b9f4/attachment.bin>