[PATCH] D156416: [RemarkUtil] Refactor remarkutil tool to use a command registry.

Zain Jaffal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 04:14:23 PDT 2023


zjaffal created this revision.
zjaffal added reviewers: thegameg, fhahn, paquette, anemet, JDevlieghere.
Herald added a subscriber: StephenFan.
Herald added a project: All.
zjaffal requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

In preperation to move all remark utilities into one tool. We use
command registry to breakdown each utility into a separate file.

For now we have 3 utilities for remarks

1. Convert: which is responsible for converting yaml remarks to bitstream and vice-versa
2. Count: Analyse remarks and report count. This currently only supports asm-remarks and annotation-summary remarks.
3. Diff remarks: Currently we only have a diff for size remarks using `llvm-remark-size-diff`

The first two utilites have been simplified and seperated into two
files. The following commit will move `llvm-remark-size-diff` and fold
it to be inside `llvm-remarkutil` as a subcommand


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D156416

Files:
  llvm/tools/llvm-remarkutil/CMakeLists.txt
  llvm/tools/llvm-remarkutil/RemarkConvert.cpp
  llvm/tools/llvm-remarkutil/RemarkCount.cpp
  llvm/tools/llvm-remarkutil/RemarkUtil.cpp
  llvm/tools/llvm-remarkutil/RemarkUtilHelpers.cpp
  llvm/tools/llvm-remarkutil/RemarkUtilHelpers.h
  llvm/tools/llvm-remarkutil/RemarkUtilRegistry.cpp
  llvm/tools/llvm-remarkutil/RemarkUtilRegistry.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156416.544698.patch
Type: text/x-patch
Size: 39416 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230727/8c671e9f/attachment.bin>


More information about the llvm-commits mailing list