[PATCH] D156408: [AMDGPU] Update amdgpu_cs_chain_preserve docs. NFC

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 03:11:49 PDT 2023


rovka created this revision.
Herald added subscribers: kerbowa, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
rovka requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

We no longer allow calls to functions with the `amdgpu_gfx` calling
convention from functions with the `amdgpu_cs_chain_preserve` calling
convention. See D153517 <https://reviews.llvm.org/D153517>.

Also mention that we can't have a chain call from
amdgpu_cs_chain_preserve using more VGPRs than it has received.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D156408

Files:
  llvm/docs/AMDGPUUsage.rst


Index: llvm/docs/AMDGPUUsage.rst
===================================================================
--- llvm/docs/AMDGPUUsage.rst
+++ llvm/docs/AMDGPUUsage.rst
@@ -1195,6 +1195,8 @@
                                      uniform control flow.
 
      ``amdgpu_cs_chain_preserve``    Same as ``amdgpu_cs_chain``, but active lanes for VGPRs starting at v8 are preserved.
+                                     Calls to ``amdgpu_gfx`` functions are not allowed, and any calls to ``llvm.amdgcn.cs.chain``
+                                     must not pass more VGPR arguments than the caller VGPR function parameters.
 
      ``amdgpu_es``                   Used for AMDPAL shader stage before geometry shader if geometry is in
                                      use. So either the domain (= tessellation evaluation) shader if


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156408.544676.patch
Type: text/x-patch
Size: 826 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230727/fcbd063a/attachment.bin>


More information about the llvm-commits mailing list