[PATCH] D156397: [FunctionAttrs] Unconditionally perform argument attribute inference in the first function-attrs pass
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 27 00:28:50 PDT 2023
nikic added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:1769
CGSCCUpdateResult &) {
// Skip non-recursive functions if requested.
+ bool ArgAttrsOnly = false;
----------------
Add some extra comment here: "Only infer readonly etc on arguments in that case, because it can affect optimization behavior in conjunction with noalias" or something like that.
================
Comment at: llvm/test/Transforms/PhaseOrdering/arg-attrs-affect-earlycse.ll:174
+
+!0 = !{i32 8, !"PIC Level", i32 1}
----------------
It should be possible to massively simplify this test by using the memssa-check-limit option.
Please drop all the irrelevant noise, especially anything related to address spaces.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156397/new/
https://reviews.llvm.org/D156397
More information about the llvm-commits
mailing list