[PATCH] D156393: [RISCV] Fix getMaxPushPopReg like getLibCallID

Yeting Kuo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 23:43:08 PDT 2023


fakepaper56 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:270
   for (auto &CS : CSI) {
-    Register Reg = CS.getReg();
-    if (RISCV::PGPRRegClass.contains(Reg)) {
-      MaxPushPopReg = std::max(MaxPushPopReg.id(), Reg.id());
+    // RISCVRegisterInfo::hasReservedSpillSlot assigns negative frame indexes to
+    // registers which can be saved by Push.
----------------
indexes -> indices.
by Push -> by Zcmp Push.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156393/new/

https://reviews.llvm.org/D156393



More information about the llvm-commits mailing list