[PATCH] D156377: [CMake] Use `LLVM_ENABLE_ASSERTIONS` to enable the hardened mode in libc++.

[Konstantin Varlamov via Phabricator via llvm-commits]

var-const added a comment.

The CI failure appears unrelated:

  _bk;t=1690424766404******************** TEST 'Clang :: AST/Interp/literals.cpp' FAILED ********************
  _bk;t=1690424766404Script:
  _bk;t=1690424766404--
  _bk;t=1690424766404: 'RUN: at line 1';   c:\ws\w3\llvm-project\premerge-checks\build\bin\clang.exe -cc1 -internal-isystem c:\ws\w3\llvm-project\premerge-checks\build\lib\clang\18\include -nostdsysteminc -fexperimental-new-constant-interpreter -fms-extensions -std=c++11 -verify C:\ws\w3\llvm-project\premerge-checks\clang\test\AST\Interp\literals.cpp
  _bk;t=1690424766404: 'RUN: at line 2';   c:\ws\w3\llvm-project\premerge-checks\build\bin\clang.exe -cc1 -internal-isystem c:\ws\w3\llvm-project\premerge-checks\build\lib\clang\18\include -nostdsysteminc -fexperimental-new-constant-interpreter -fms-extensions -std=c++20 -verify C:\ws\w3\llvm-project\premerge-checks\clang\test\AST\Interp\literals.cpp
  _bk;t=1690424766404: 'RUN: at line 3';   c:\ws\w3\llvm-project\premerge-checks\build\bin\clang.exe -cc1 -internal-isystem c:\ws\w3\llvm-project\premerge-checks\build\lib\clang\18\include -nostdsysteminc -std=c++11 -fms-extensions -verify=ref C:\ws\w3\llvm-project\premerge-checks\clang\test\AST\Interp\literals.cpp
  _bk;t=1690424766404: 'RUN: at line 4';   c:\ws\w3\llvm-project\premerge-checks\build\bin\clang.exe -cc1 -internal-isystem c:\ws\w3\llvm-project\premerge-checks\build\lib\clang\18\include -nostdsysteminc -std=c++20 -fms-extensions -verify=ref C:\ws\w3\llvm-project\premerge-checks\clang\test\AST\Interp\literals.cpp
  _bk;t=1690424766404--
  _bk;t=1690424766404Exit Code: 1
  _bk;t=1690424766404
  _bk;t=1690424766404Command Output (stdout):
  _bk;t=1690424766404--
  _bk;t=1690424766404$ ":" "RUN: at line 1"
  _bk;t=1690424768343$ "c:\ws\w3\llvm-project\premerge-checks\build\bin\clang.exe" "-cc1" "-internal-isystem" "c:\ws\w3\llvm-project\premerge-checks\build\lib\clang\18\include" "-nostdsysteminc" "-fexperimental-new-constant-interpreter" "-fms-extensions" "-std=c++11" "-verify" "C:\ws\w3\llvm-project\premerge-checks\clang\test\AST\Interp\literals.cpp"
  _bk;t=1690424768347# command stderr:
  _bk;t=1690424768347error: 'warning' diagnostics seen but not expected: 
  _bk;t=1690424768347  File C:\ws\w3\llvm-project\premerge-checks\clang\test\AST\Interp\literals.cpp Line 946: cast to smaller integer type 'long' from 'char *'
  _bk;t=16904247683471 error generated.
  _bk;t=1690424768347
  _bk;t=1690424768347error: command failed with exit status: 1

I will go ahead and merge this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156377/new/

https://reviews.llvm.org/D156377