[PATCH] D142880: [RISCV][LLD] Support R_RISCV_SET_ULEB128 and R_RISCV_SUB_ULEB128

[Khem Raj via Phabricator via llvm-commits]

raj.khem added a comment.

In D142880#4537432 <https://reviews.llvm.org/D142880#4537432>, @raj.khem wrote:

> In D142880#4534918 <https://reviews.llvm.org/D142880#4534918>, @asb wrote:
>
>> Just cross-linking to https://github.com/llvm/llvm-project/issues/64102 - as we discussed at the last RISC-V LLVM sync-up we really would like to land this and get it into the LLVM 17 branch if possible, to avoid compatibility issues with the next binutils release.
>
> For cross reference. this review https://reviews.llvm.org/D142879 also needs to land together with this.

I tried the existing patches as such on top 17.x branch and it crashes lld

  | 0  libLLVM-17.so            0x00007f1bef819be4 llvm::sys::RunSignalHandlers() + 52
  | 1  libLLVM-17.so            0x00007f1bef819d56
  | 2  libc.so.6                0x00007f1bee65b6e0
  | 3  riscv64-yoe-linux-ld.lld 0x00005595e8159d5e lld::elf::Symbol::getVA(long) const + 30
  | 4  riscv64-yoe-linux-ld.lld 0x00005595e8214dd1
  | 5  riscv64-yoe-linux-ld.lld 0x00005595e81081be void lld::elf::InputSection::relocateNonAlloc<llvm::object::ELFType<(llvm::support::endianness)1, true>, llvm::object::Elf_Rel_Impl<llvm::object::ELFType<(llvm::support::endianness)1, true>, true>>(unsigned char*, llvm::ArrayRef<llvm::object::Elf_Rel_Impl<llvm::object::ELFType<(llvm::support::endianness)1, true>, true>>) + 1886
  | 6  riscv64-yoe-linux-ld.lld 0x00005595e813b5a3
  | 7  libLLVM-17.so            0x00007f1bef785fd6
  | 8  libLLVM-17.so            0x00007f1bef786b84
  | 9  libstdc++.so.6           0x00007f1bee8df5e3
  | 10 libc.so.6                0x00007f1bee6a5d63
  | 11 libc.so.6                0x00007f1bee7247e0
  | riscv64-yoe-linux-clang: error: unable to execute command: Segmentation fault (core dumped)
  |


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142880/new/

https://reviews.llvm.org/D142880