[PATCH] D156346: CodeGen: Disable isCopyInstrImpl if there are implicit operands

Wed Jul 26 16:31:17 PDT 2023

vitalybuka added a comment.

In D156346#4537085 <https://reviews.llvm.org/D156346#4537085>, @arsenm wrote:

> In D156346#4536935 <https://reviews.llvm.org/D156346#4536935>, @vitalybuka wrote:
>
>> Just tried, this one does not solve the issue. Or it probably introduce a different miscompile. UBSan report is gone, but the test fails text expectations. With stable ( before D150388 <https://reviews.llvm.org/D150388> ) compiler the test consistently green.
>>
>> D156164 <https://reviews.llvm.org/D156164> also makes the test consistently green.
>
> To clarify did you only apply this patch? You need the whole stack. This one in isolation won’t fix it

yes, only the last one
arc patch does not apply entire stack, probably patches need to be rebased/uploaded

my 2c: if it's entire stack then revert D156381 <https://reviews.llvm.org/D156381> is more appropriate solution

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156346/new/

https://reviews.llvm.org/D156346