[PATCH] D154984: [lit] Drop "Script:", make -v and -a imply -vv

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D154984#4536987 <https://reviews.llvm.org/D154984#4536987>, @MaskRay wrote:

> If the internal shell can collect `Command Output (stdout):` and stderr and print them after all RUN commands are dumped, we can remove the prompts.

I specifically want to see which command printed which part of the output.  Separating them as you suggest would lose that information.

What if we put the output in shell comments so it has no effect when pasted into a terminal?

> I think many more developers work on non-Windows platforms and get external shell by default, and very few people know `LIT_USE_INTERNAL_SHELL=1`.

I don't normally use that environment variable.  Instead, I configure the test suite permanently with the following in its `lit.cfg`:

  config.test_format = lit.formats.ShTest(execute_external=False)



> If we can make the internal shell work well enough and make it the default for non-Windows platforms, that's fine with me.

I'm not sure we can change the lit default in general.  Some test suites might still require external shell features that lit's internal shell doesn't support.  Instead, we can change it per test suite, as shown above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154984/new/

https://reviews.llvm.org/D154984