[PATCH] D155793: [Support] Avoid wait4 on Fuchsia

Roland McGrath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 16:14:56 PDT 2023


mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.

Fuchsia also doesn't actually provide wait or waitpid, so some more comments to that effect at least in the log would be useful. It also doesn't have signals, so the calls earlier in the function won't actually do anything.
It probably makes more sense to just define `llvm::sys::Wait` so that it always fails without any real implementation contents under `#ifdef __Fuchsia__`.



================
Comment at: llvm/lib/Support/Unix/Program.inc:465
+#ifndef __Fuchsia__
   if (ProcStat) {
     std::chrono::microseconds UserT = toDuration(Info.ru_utime);
----------------
Probably makes sense to set `ProcStat->reset();` rather than not touching the output when we have no data.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155793/new/

https://reviews.llvm.org/D155793



More information about the llvm-commits mailing list