[PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin
Jason Molenda via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 26 15:55:01 PDT 2023
jasonmolenda added a comment.
In D156086#4530507 <https://reviews.llvm.org/D156086#4530507>, @RamNalamothu wrote:
> In D156086#4529791 <https://reviews.llvm.org/D156086#4529791>, @jasonmolenda wrote:
>
>>
>> Does `isBranch` include other variants like `isUnconditionalBranch`?
>
> No. They are implemented as separate methods. You can see that with a full context diff of MCInstrAnalysis.h changes in this revision or MCInstrAnalysis.h <https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/MC/MCInstrAnalysis.h>
`mayAffectControlFlow` doesn't test for `isUnconditionalBranch`. Is that a problem? I didn't look through the different property check methods like this, but I happened to notice this one and see it wasn't detected in `mayAffectControlFlow`. Maybe I misunderstood something.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156086/new/
https://reviews.llvm.org/D156086
More information about the llvm-commits
mailing list