[PATCH] D155535: [WebAssembly][Objcopy] Write output section headers identically to inputs

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: llvm/test/ObjectYAML/wasm/invalid_section_header_size.yaml:1
+## Test if we correctly error out if the provided section header size is less
+## than the size required.
----------------
jhenderson wrote:
> Rather than spin this off into a separate test file, I think it should be part of the existing section_header_size.yaml test. You could use either --docnum to allow you to have multiple YAML docs in the same file, or you could use yaml2obj's -D option to parmaterise an existing section header length field to be the appropriate too-small value.
Thanks! Didn't know about those options.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155535/new/

https://reviews.llvm.org/D155535