[PATCH] D155818: [CloneFunction][DebugInfo] Clone DISubprogram's local types

Wed Jul 26 12:00:13 PDT 2023

dblaikie added a comment.

In D155818#4531577 <https://reviews.llvm.org/D155818#4531577>, @dzhidzhoev wrote:

> In D155818#4529566 <https://reviews.llvm.org/D155818#4529566>, @dblaikie wrote:
>
>>> Additionally, when tracking function-local types in the DICompileUnit (via retainedTypes or enums fields), it seems reasonable to track the clones as well.
>>
>> Hmm, when do we have function-local types in the DICompileUnit list? I thought we always put those on the subprogram now?
>
> The commit with this change https://reviews.llvm.org/D144006 was reverted because of the crash I'm trying to fix here. Since I will commit this before https://reviews.llvm.org/D144006, if it gets accepted xD, we technically still have function-local types in the DICompileUnit list.

So this code would be removed once D144006 <https://reviews.llvm.org/D144006> goes in? Perhaps we could review them separately but assuming they go in together (they could be squashed together before committing) if it's causing this much extra code that'd only exist for 1-2 commits anyway?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155818/new/

https://reviews.llvm.org/D155818