[PATCH] D156077: [AMDGPU] Propagate constants for llvm.amdgcn.wave.reduce.umin/umax

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with the spurious include dropped



================
Comment at: llvm/lib/Analysis/ConstantFolding.cpp:63
 
+#include <iostream>
 using namespace llvm;
----------------
Don't add new include


================
Comment at: llvm/test/Transforms/InstSimplify/ConstProp/AMDGPU/wave.reduce.ll:64
+
+ at gv = constant i32 0
+define amdgpu_kernel void @test_constant_fold_wave_reduce_umax_gv(ptr addrspace(1) %out) {
----------------
pravinjagtap wrote:
> This usecase is not being optimized (const-fold).
Don't see why that would be but it's unimportant


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156077/new/

https://reviews.llvm.org/D156077