[PATCH] D156306: [RISCV][NFC] Change type of isOrdered to boolean

[Wang Pengcheng via Phabricator via llvm-commits]

wangpc added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:268
 
 // Indexed Segment Loads and Stores
+class VLXSEGSched<int nf, int eew, bit isOrdered, string emul,
----------------
michaelmaitland wrote:
> Do we need to use an argument to accomplish selection of `O` and `U` in addition to passing `isOrdered`? It's a little confusing to the user of this class that they should never pass the `order` argument. I think it would be a better interface to use `!if()` twice to avoid adding complexity for users of this class. WDYT?
As what I said in description, I just use it to eliminate redundancies. But you are right, this can be confusing.
I will change it tomorrow. :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156306/new/

https://reviews.llvm.org/D156306