[PATCH] D155743: [AggressiveInstCombine] Fold strcmp for short string literals with size 2

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n accepted this revision.
goldstein.w.n added a comment.
This revision is now accepted and ready to land.

LGTM.

Not really familiar enough with AggressiveInstCombine to be only reviewer here so please wait at least a few days to a second signoff.



================
Comment at: llvm/lib/Transforms/AggressiveInstCombine/AggressiveInstCombine.cpp:1007
+        BasicBlock::Create(B.getContext(), "strcmp_expand_sub_is_zero",
+                           InitialBB->getParent(), JoinBlock);
+    B.CreateCondBr(IsCharacterSubZero, IsCharacterSubZeroBB, JoinBlock);
----------------
nit can you rename `*SubZero*` variables -> `*SubIsZero*` or `*Eq*` (I first read 'SubZero' as negative).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155743/new/

https://reviews.llvm.org/D155743