[PATCH] D156016: [Support] Change MapVector's default template parameter to SmallVector<*, 0>

Wed Jul 26 09:12:56 PDT 2023

MaskRay added a comment.

In D156016#4534190 <https://reviews.llvm.org/D156016#4534190>, @yrouban wrote:

> In D156016#4533783 <https://reviews.llvm.org/D156016#4533783>, @tianshilei1992 wrote:
>
>> I can confirm that 6a684dbc4433a33e5f94fb15c9e378a2408021e0 <https://reviews.llvm.org/rG6a684dbc4433a33e5f94fb15c9e378a2408021e0> fixed the build with GCC 7.5.0. Thanks.
>
> We should have a buildbot that uses GCC 7.5.0 to check build issues before they are landed.

Yes, but the reality is that we don't have one. I think we may have a GCC 8 bot.
The last paragraph of https://discourse.llvm.org/t/require-gcc-7-5-as-gcc-7-3-cannot-build-llvm/72310 says that we should have bots for the minimum GCC version we want to support :)

In D156016#4535650 <https://reviews.llvm.org/D156016#4535650>, @srj wrote:

> In D156016#4533783 <https://reviews.llvm.org/D156016#4533783>, @tianshilei1992 wrote:
>
>> I can confirm that 6a684dbc4433a33e5f94fb15c9e378a2408021e0 <https://reviews.llvm.org/rG6a684dbc4433a33e5f94fb15c9e378a2408021e0> fixed the build with GCC 7.5.0. Thanks.
>
> FYI, apparently this fix needs to be backported to the `release/17.x` branch as well.

Yes. I filed https://github.com/llvm/llvm-project/issues/64117

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156016/new/

https://reviews.llvm.org/D156016