[PATCH] D152407: [AArch64] Merge LDRSWpre-LD[U]RSW pair into LDPSWpre.

Wed Jul 26 06:42:18 PDT 2023

alexfh added a comment.

In D152407#4534575 <https://reviews.llvm.org/D152407#4534575>, @asmok-g wrote:

>> Thanks for reporting and reproducing the miscompilation!  It looks like two pre-indexed loads `LDRSWpre` and `LDRWpre` got merged into a `LDPWpre` and `SBFMXri`, which is an unintended result by this patch.  I think we can either rollback this patch or apply a quick fix that disallows merging two pre-indexed loads like the following.  Any thoughts?
>
> Hi there! I'm not an expert here, but speaking with @scw and he thinks the fix doesn't address the "sxtw on wrong register bug". He'll probably be able to comment with details later but his vote is to rollback for now. Can you please do ?
>
> Thanks

Sent a revert: https://reviews.llvm.org/D156328 (will commit after the precommit checks finish).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152407/new/

https://reviews.llvm.org/D152407