[PATCH] D156190: [llvm-objdump] -d: don't display mapping symbols as labels

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/include/llvm/MC/MCDisassembler/MCDisassembler.h:48
   SymbolInfoTy(uint64_t Addr, StringRef Name, uint8_t Type,
-               bool IsXCOFF = false)
-      : Addr(Addr), Name(Name), Type(Type), IsXCOFF(IsXCOFF), HasType(true) {}
+               bool FormatSpecific = false, bool IsXCOFF = false)
+      : Addr(Addr), Name(Name), Type(Type), IsMappingSymbol(FormatSpecific),
----------------
It's not clear to me purely from the name that `FormatSpecific` and `IsMappingSymbol` should be synonymous. Coudl this parameter simply be called `IsMappingSymbol` too (or possibly `IsELFMappingSymbol`)?


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1368-1370
+      // For a mapping symbol, store it within AllMappingSymbols. If
+      // --show-all-symbols is specified, save it in AllSymbols so its label
+      // will be printed; otherwise its label should not be displayed.
----------------
I might be missing something obvious, but I don't see how the code below means the mapping symbol is only stored in `AllSymbols` if --show-all-symbols is specified?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156190/new/

https://reviews.llvm.org/D156190