[PATCH] D156293: [lld][ELF][test] Fix excessive output file size in loongarch-add-sub.s
WÁNG Xuěruì via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 25 22:25:14 PDT 2023
xen0n created this revision.
xen0n added reviewers: SixWeining, MaskRay, xry111.
Herald added subscribers: kristof.beyls, emaste.
Herald added a project: All.
xen0n requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Initially the .rodata section came before .text, hence sharing its
segment with the program header sitting at a small offset, pushing the
output file size to ~72GiB (the file was sparse though, so not much is
really written). This breaks on 32-bit platforms and is irrelevant to
the feature being tested, so re-order the two sections so .text gets
processed first, and both sections get their own segment.
This addresses the issue found by the clang-armv8-lld-2stage builder:
https://lab.llvm.org/buildbot/#/builders/178/builds/5340
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D156293
Files:
lld/test/ELF/loongarch-add-sub.s
Index: lld/test/ELF/loongarch-add-sub.s
===================================================================
--- lld/test/ELF/loongarch-add-sub.s
+++ lld/test/ELF/loongarch-add-sub.s
@@ -2,14 +2,14 @@
# RUN: llvm-mc --filetype=obj --triple=loongarch64-unknown-elf %s -o %t.la64.o
-# RUN: ld.lld --section-start=.rodata=0x1234567890 --section-start=.text=0x9876543210 %t.la64.o -o %t.la64
+# RUN: ld.lld --section-start=.text=0x1234567890 --section-start=.rodata=0x9876543210 %t.la64.o -o %t.la64
# RUN: llvm-readelf -x .rodata %t.la64 | FileCheck --check-prefix=CHECK %s
# CHECK: section '.rodata':
-# CHECK-NEXT: 0x1234567890 10325476 98badcfe 80b9fd41 86000000
-# CHECK-NEXT: 0x12345678a0 80b9fd41 80b980
+# CHECK-NEXT: 0x9876543210 10325476 98badcfe 804602be 79ffffff
+# CHECK-NEXT: 0x9876543220 804602be 804680
+.text
.global _start
-
_start:
1:
break 0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156293.544208.patch
Type: text/x-patch
Size: 879 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230726/9361acb9/attachment.bin>
More information about the llvm-commits
mailing list