[PATCH] D156291: [llvm-objdump] Remove bool MachOOnlyFirst from printPrivateHeaders. NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 21:56:40 PDT 2023


MaskRay created this revision.
MaskRay added a reviewer: jhenderson.
Herald added subscribers: pmatos, asb, sbc100.
Herald added a project: All.
MaskRay requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

Mach-O can just use the global variable `FirstPrivateHeader`.
If we ever manage to remove global variables, we can add a Config
variable to Dumper. Either case, the parameter is not needed.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D156291

Files:
  llvm/tools/llvm-objdump/COFFDump.cpp
  llvm/tools/llvm-objdump/ELFDump.cpp
  llvm/tools/llvm-objdump/MachODump.cpp
  llvm/tools/llvm-objdump/WasmDump.cpp
  llvm/tools/llvm-objdump/XCOFFDump.cpp
  llvm/tools/llvm-objdump/llvm-objdump.cpp
  llvm/tools/llvm-objdump/llvm-objdump.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156291.544200.patch
Type: text/x-patch
Size: 4901 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230726/2a33a648/attachment.bin>


More information about the llvm-commits mailing list