[PATCH] D156272: [AArch64] [XRay] Account for XRay event instrs in Branch Relaxation

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 18:41:20 PDT 2023


paquette added a comment.

Can you add comments explaining the size in bytes?

"This expands to an XRay sled can be at most N instructions = M bytes"

Or something



================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:131
   case TargetOpcode::PATCHABLE_FUNCTION_ENTER:
+    NumBytes =
+        F.getFnAttributeAsParsedInteger("patchable-function-entry", 9) * 4;
----------------
comment?


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:140
+  case TargetOpcode::PATCHABLE_EVENT_CALL:
+    NumBytes = 24;
+    break;
----------------
comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156272/new/

https://reviews.llvm.org/D156272



More information about the llvm-commits mailing list