[PATCH] D156203: [AIX][TLS] Add target attribute for -maix-small-local-exec-tls option.

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 16:19:04 PDT 2023


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/check-aix-small-local-exec-tls-opt-IRattribute.ll:13-14
+; Check that the aix-small-local-exec-tls attribute is not supported on Linux and AIX (32-bit).
+; CHECK-NOT-SUPPORTED: The aix-small-local-exec-tls attribute is only supported on AIX in 64-bit mode.
+; CHECK-NOT-SUPPORTED-AIX32: The aix-small-local-exec-tls attribute is only supported on AIX in 64-bit mode.
+
----------------
Same comment re: check prefixes.


================
Comment at: llvm/test/CodeGen/PowerPC/check-aix-small-local-exec-tls-opt.ll:16-17
+; Check that the aix-small-local-exec-tls attribute is not supported on Linux and AIX (32-bit).
+; CHECK-NOT-SUPPORTED: The aix-small-local-exec-tls attribute is only supported on AIX in 64-bit mode.
+; CHECK-NOT-SUPPORTED-AIX32: The aix-small-local-exec-tls attribute is only supported on AIX in 64-bit mode.
+
----------------
No need for different check prefixes if the expected output is the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156203/new/

https://reviews.llvm.org/D156203



More information about the llvm-commits mailing list