[PATCH] D156265: RegisterCoalescer: Remove dubious dropping of implicit virtual register defs

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: qcolombet, kparzysz, lhames, bogner.
Herald added subscribers: tpr, hiraditya, MatzeB.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

Don't understand why this would either be OK or necessary, but doesn't
appear to happen in any tests. This was introduced way back in
76e66c31a0481e72d1ff86c56028d850b6c33cff


https://reviews.llvm.org/D156265

Files:
  llvm/lib/CodeGen/RegisterCoalescer.cpp


Index: llvm/lib/CodeGen/RegisterCoalescer.cpp
===================================================================
--- llvm/lib/CodeGen/RegisterCoalescer.cpp
+++ llvm/lib/CodeGen/RegisterCoalescer.cpp
@@ -1396,9 +1396,8 @@
     MachineOperand &MO = CopyMI->getOperand(I);
     if (MO.isReg()) {
       assert(MO.isImplicit() && "No explicit operands after implicit operands.");
-      // Discard VReg implicit defs.
-      if (MO.getReg().isPhysical())
-        ImplicitOps.push_back(MO);
+      assert(MO.getReg().isPhysical() && "unexpected implicit virtual register def");
+      ImplicitOps.push_back(MO);
     }
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156265.544108.patch
Type: text/x-patch
Size: 623 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230725/9ce6c19a/attachment.bin>