[PATCH] D156136: [BPF] Clean up SelLowering

Tamir Duberstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 09:47:52 PDT 2023


tamird added a comment.

In D156136#4532425 <https://reviews.llvm.org/D156136#4532425>, @ast wrote:

> Way too many unrelated changes. Please abandon. Don't see a value in any of them.

Can you help me understand why the current shape of this code is better? My position is that this improves the quality of the code and the errors emitted by it as described in an earlier comment. It also brings this file into closer conformance with LLVM coding standards as defined in clang-tidy configs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156136/new/

https://reviews.llvm.org/D156136



More information about the llvm-commits mailing list