[PATCH] D152973: Reland "[gold] Add preliminary FatLTO support to the Gold plugin""

Tue Jul 25 07:00:40 PDT 2023

peter.smith added a comment.

In D152973#4529625 <https://reviews.llvm.org/D152973#4529625>, @paulkirth wrote:

> @peter.smith @nikic @maskray @tejohnson, given that Rust and others seem to use the `.llvmbc`, I see a few ways we can move forward here.
>
> 1. have a hard transition (e..g., this patch), and make downstream consumers adapt now.
> 2. have a soft transition, and mark `.llvmbc` as deprecated, then remove in the following release (so about 6 months from now).
> 3. forgo trying to separate the old uses of `.llvmbc` from new FatLTO uses and just reuse the `.llvmbc` section name.
> 4. ... something completely different?
>
> I'm not really sure what the best way to go about this would be. I'd lean towards a soft transition (2), since that seems more forgiving and less hostile towards downstream consumers, but I think there are merits for any of the approaches.  There are probably other options I haven't considered either, so thoughts and suggestions would be quite welcome.

I think we can adapt fairly quickly as it is an embedded toolchain and we don't support mixing LTO objects from previous versions, I think we'll be able to cope with an instant change. May be worth an RFC/FYI on Discourse as some downstream projects merge with upstream less frequently than we do.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152973/new/

https://reviews.llvm.org/D152973