[PATCH] D156095: [Bazel] Introduce `//compiler-rt:profile`
NAKAMURA Takumi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 25 06:57:54 PDT 2023
chapuni added inline comments.
================
Comment at: utils/bazel/llvm-project-overlay/compiler-rt/BUILD.bazel:37
+ "-Wno-pedantic",
+ "-Wno-strict-prototypes",
+ ],
----------------
paquette wrote:
> chapuni wrote:
> > aeubanks wrote:
> > > MaskRay wrote:
> > > > Are the two -Wno- needed?
> > > should just fix the sources instead if these are finding real issues
> > `-Wno-strict-prototypes` was redundant. It has been there since I checked `-std=c11` for `strdup`.
> >
> > `-Wno-pedantic` is required since my environment enforces `-pedantic`. I know compiler-rt doesn't like `-pedantic`. I will remove `-pedantic` in my environment.
> +1
`copts` may be pruned if `-pedantic` is not given.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156095/new/
https://reviews.llvm.org/D156095
More information about the llvm-commits
mailing list