[PATCH] D155542: [lld][WebAssembly] Fix func reloc for internal GOT with extended-const

[YAMAMOTO Takashi via Phabricator via llvm-commits]

yamt added inline comments.


================
Comment at: lld/test/wasm/Inputs/internal_func.ll:11
+  ret ptr null
+}
----------------
sbc100 wrote:
> For new test files could you add them as `.s` files?   I've been trying to convert all the `.ll` files for `.s` over time but have yet to finish that work.
> 
> It should be that same or fewer lines I think.
ok


================
Comment at: lld/test/wasm/pie.ll:39
+  ret ptr @internal_func2
+}
+
----------------
sbc100 wrote:
> Why define two different internal funcs?
because one of them happened to have offset 0.


================
Comment at: lld/wasm/SyntheticSections.cpp:488
+    bool use_extended_const = false;
+    uint32_t global_idx;
+    int64_t offset;
----------------
sbc100 wrote:
> llvm coding style uses camel case for locals so this would be `useExtendedConst` and `globalIdx`
ok


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155542/new/

https://reviews.llvm.org/D155542