[PATCH] D155638: [llvm-reduce] Reduce function calling convention

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D155638#4520748 <https://reviews.llvm.org/D155638#4520748>, @arsenm wrote:

> In D155638#4517796 <https://reviews.llvm.org/D155638#4517796>, @nikic wrote:
>
>> I think we have a lot of precedent for this. For example, we reduce away the "dso_local" flag, which is a simplification on the IR level, but likely makes codegen more complex. Similarly, we reduce globals to external linkage -- again, this likely makes codegen more complex. Etc.
>
> This isn't a great analog. dso_local at least fits the mold of an optimization flag. It's not something mandatory. A target should have the right to not implement CCC at all and only use custom calling conventions (this was the case for AMDGPU at the very beginning for example).

So the concern here is that if a target doesn't implement it, then it's likely that we'll get a false positive interesting test when run against something like `! llc`? I think for that particular case (CCC not supported) it would be fine to opt-out the relevant calling convention.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155638/new/

https://reviews.llvm.org/D155638