[PATCH] D153260: [RISCV][MC] Implement mapping symbols

Tue Jul 25 02:29:28 PDT 2023

jobnoorman added a comment.

In D153260#4530280 <https://reviews.llvm.org/D153260#4530280>, @MaskRay wrote:

>> Note on testing: several tests needed to be updated for this patch. This was mainly caused by the introduction of new symbols causing the labels in llvm-objdump to change.
>
> I think we should fix llvm-objdump -d to not display mapping symbols... This unfortunately requires updates to many lld/test/ELF tests:  https://reviews.llvm.org/D156190

That makes sense, thanks for submitting the patch!

Just to be clear: you prefer that this patch be rebased on D156190 <https://reviews.llvm.org/D156190> in order to not have to update the tests, right? In that case, I'll have to slightly extend this patch to set the `SF_FormatSpecific` ELF flag on mapping symbols in RISC-V. I think this should be fine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153260/new/

https://reviews.llvm.org/D153260