[PATCH] D156204: [PowerPC][MC] Recognize tlbilx and its mnemonics

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added a comment.

In D156204#4530957 <https://reviews.llvm.org/D156204#4530957>, @qiucf wrote:

> The motivation is https://github.com/llvm/llvm-project/issues/64080
>
> I see both GCC and XLC 16 recognize the instruction in inlineasm.
>
> The instruction (`tlbilx`) can be found in ISA 2.07 but eliminated in 3.0 and 3.1 since it belongs to 'Book III-E'. Not sure if it should be implemented in current PPC backend. So I put this in draft mode.
>
>> In support of the OpenPOWER Foundation’s standardization of server architecture, Power ISA Version 3.0 streamlined this integration by choosing a single Book III and a set of widely used categories to become part of the base architecture for all forward-looking Power implementations. All other optional architecture categories were eliminated to ensure increased application portability between Power processors. Legacy embedded applications that require the eliminated material will continue to use V. 2.07B.
>>
>> -Preface of ISA 3.0

OK, thanks for clarifying. I am not against implementing this instruction and its aliases, but I think that anything from these removed optional categories should only be implemented with good justification. Needing it in the kernel builds is adequate justification in my opinion. Please update the description to mention the bug this is resolving.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156204/new/

https://reviews.llvm.org/D156204