[PATCH] D138135: [lld][ELF] Support LoongArch

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/ELF/Arch/LoongArch.cpp:23
+namespace {
+
+class LoongArch final : public TargetInfo {
----------------
delete blank line


================
Comment at: lld/ELF/Arch/LoongArch.cpp:41
+};
+
+} // end anonymous namespace
----------------
delete blank line


================
Comment at: lld/ELF/Arch/LoongArch.cpp:114
+  //     dest = U + T
+  //          = (RQ<<32 + P<<12 + i + b<<12) + (j + k + A + cd<<32)
+  //          = ((RQ+cd)<<32 + i + j) + ((P+b)<<12 + k) + A
----------------
`<<` needs some parentheses due to operator precedence :)


================
Comment at: lld/test/ELF/loongarch-abs64.s:65
+    lu52i.d $a1, $a1, %abs64_hi12(bar)
+
----------------
delete trailing blank line


================
Comment at: lld/test/ELF/loongarch-pcala-lo12-jirl-shared.s:17
+# DIS:        234020:   pcaddu12i   $t3, 510
+# DIS32-NEXT: 234024:   ld.w    $t3, $t3, 84
+# DIS64-NEXT: 234024:   ld.d    $t3, $t3, 184
----------------
Delete addresses for instructions that are not referenced. Fewer addresses makes test updating easier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138135/new/

https://reviews.llvm.org/D138135