[PATCH] D155535: [WebAssembly][Objcopy] Write output section headers identically to inputs

Tue Jul 25 00:08:15 PDT 2023

jhenderson added a comment.

Looks like a bundle of the pre-merge checks are failing due to this latest patch? Otherwise, this basically looks good to me, barring a couple of nits.

================
Comment at: llvm/lib/ObjectYAML/WasmEmitter.cpp:652
+    if (HeaderSecSizeEncodingLen < getULEB128Size(OutString.size())) {
+      reportError("Section length can't be encoded in an LEB of size " +
+                  Twine(HeaderSecSizeEncodingLen));
----------------
LLVM coding standards state that this should be a lower-case letter.

A simple test case for the new error would be good too.

================
Comment at: llvm/test/ObjectYAML/wasm/section_header_size.yaml:72
+# CHECK-NEXT:         Body:            200020016A0B
\ No newline at end of file

----------------
jhenderson wrote:
> Nit: new line at EOF.
Ping this comment?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155535/new/

https://reviews.llvm.org/D155535