[PATCH] D155600: [AIX][TLS] Produce a faster local-exec access sequence with -maix-small-local-exec-tls (And optimize when load/store offsets are 0)

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1525-1527
+    // Handle assembly printing for -maix-small-local-exec-tls on AIX (64-bit).
+    if (emitAIXSmallLocalExecTLSAccess(MI, TmpInst))
+        return;
----------------
Not a single test failed when I removed this. Perhaps this does not belong in this patch (but a future one)?


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1542-1559
+  case PPC::LBZ:
+  case PPC::STB:
+  case PPC::LBZ8:
+  case PPC::STB8:
+  case PPC::LHA:
+  case PPC::LHZ:
+  case PPC::STH:
----------------
Same comment re: the cases other than `ADDI8`.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1574
+  unsigned OrigMIOpc = MI->getOpcode();
+  bool IsMIADDI8 = OrigMIOpc == PPC::ADDI8;
+  unsigned OpNum = IsMIADDI8 ? 2 : 1;
----------------
For the purposes of this patch, maybe assert up front that we are handling the `ADDI8` case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155600/new/

https://reviews.llvm.org/D155600