[PATCH] D156016: [Support] Change MapVector's default template parameter to SmallVector<*, 0>

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 21:28:57 PDT 2023


MaskRay added a comment.

In D156016#4530166 <https://reviews.llvm.org/D156016#4530166>, @JDevlieghere wrote:

> Makes sense: LGTM.
>
> Slightly tangential: If we want to encourage more use of `SmallVector`, would it make sense to make the second template argument default to `0` so that folks can just write `SmallVector<T>` or do we want to keep it explicit so users are forced to pick a sensible value?

Thank you! Yes, I think it would be nice that the default parameter is 0, but a while ago it was changed to mean like 64/sizeof(T)...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156016/new/

https://reviews.llvm.org/D156016



More information about the llvm-commits mailing list