[PATCH] D156141: [NFC][ValueTracking]: Move some code from isKnownNonZero to isKnownNonZeroFromOperator

Mon Jul 24 21:09:48 PDT 2023

0xdc03 added a comment.

In D156141#4530090 <https://reviews.llvm.org/D156141#4530090>, @goldstein.w.n wrote:

> No complaints about the code, but just curious whats the rationale? Why is `isKnownNonZeroFromOperator` a better home?

For `AllocaInst`, `isKnownNonZeroFromOperator` now holds the big switch with all the instruction types so it makes more sense to me for it to be in there.

For `CallBase`, I think it is better if the code is combined with the rest of the `CallInst` handling that is already there.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156141/new/

https://reviews.llvm.org/D156141