[PATCH] D155929: [RISCV] Use the first element of source as the start value of reduction.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:3446
+    }
+    if (ExtractedVT.bitsLE(VT))
+      return DAG.getNode(ISD::INSERT_SUBVECTOR, DL, VT, Passthru, ExtractedVal,
----------------
fakepaper56 wrote:
> craig.topper wrote:
> > Is VT here always scalable?
> I think all lowerScalarInsert calls use scalable vector VT and it looks like lowerScalarInsert can't have fixed vector VT. 
can you add an assertion?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155929/new/

https://reviews.llvm.org/D155929