[PATCH] D156095: [Bazel] Introduce `//compiler-rt:profile`

NAKAMURA Takumi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 18:14:36 PDT 2023


chapuni added a comment.

I don't have any environments for targeting Win32 at the moment.
Do we think I should make this Win32-compatible?



================
Comment at: utils/bazel/llvm-project-overlay/compiler-rt/BUILD.bazel:27
+    ], exclude = [
+        "lib/profile/WindowsMMap.c",
+    ]),
----------------
paquette wrote:
> why is this excluded?
> 
> https://github.com/llvm/llvm-project/blob/c8bcc48af628d9f1e6b0cfd3edda330f3c04ed9a/compiler-rt/lib/profile/InstrProfilingFile.c#L21
> 
> It looks like this is necessary for continuous mode on Windows?
It is excluded for non-Win32 targets also in CMake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156095/new/

https://reviews.llvm.org/D156095



More information about the llvm-commits mailing list