[PATCH] D156095: [Bazel] Introduce `//compiler-rt:profile`
Jessica Paquette via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 24 18:01:00 PDT 2023
paquette added inline comments.
================
Comment at: utils/bazel/llvm-project-overlay/compiler-rt/BUILD.bazel:27
+ ], exclude = [
+ "lib/profile/WindowsMMap.c",
+ ]),
----------------
why is this excluded?
https://github.com/llvm/llvm-project/blob/c8bcc48af628d9f1e6b0cfd3edda330f3c04ed9a/compiler-rt/lib/profile/InstrProfilingFile.c#L21
It looks like this is necessary for continuous mode on Windows?
================
Comment at: utils/bazel/llvm-project-overlay/compiler-rt/BUILD.bazel:37
+ "-Wno-pedantic",
+ "-Wno-strict-prototypes",
+ ],
----------------
aeubanks wrote:
> MaskRay wrote:
> > Are the two -Wno- needed?
> should just fix the sources instead if these are finding real issues
+1
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156095/new/
https://reviews.llvm.org/D156095
More information about the llvm-commits
mailing list