[PATCH] D153260: [RISCV][MC] Implement mapping symbols

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

> Note on testing: several tests needed to be updated for this patch. This was mainly caused by the introduction of new symbols causing the labels in llvm-objdump to change.

I think we should fix llvm-objdump -d to not display mapping symbols... This unfortunately requires updates to many lld/test/ELF tests:  https://reviews.llvm.org/D156190

Sorry that I'll go on a trip since Thursday and will be slow to respond...



================
Comment at: llvm/test/MC/RISCV/mapping-across-sections.s:1
+# RUN: llvm-mc -triple=riscv32 -filetype=obj < %s | llvm-objdump -t - | FileCheck %s
+# RUN: llvm-mc -triple=riscv64 -filetype=obj < %s | llvm-objdump -t - | FileCheck %s
----------------
Ideally use llvm-readelf for testing, which retains all `Elf*_Sym` information. llvm-objdump -t output losses some information e.g. certain ELF symbol types are not distinguishable.


================
Comment at: llvm/test/MC/RISCV/mapping-across-sections.s:12
+
+# A setion should be able to start with a $d
+        .section .starts_data
----------------
full stop for complete sentence comments


================
Comment at: llvm/test/MC/RISCV/mapping-across-sections.s:28
+# CHECK-NEXT: {{0+}} l .starts_data {{0+}} $d
+# CHECK-NOT: ${{[dx]}}
+
----------------
`# CHECK-NOT: {{.}}` is preferred to test that there is no further output. Also, avoid a blank line at the end.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153260/new/

https://reviews.llvm.org/D153260