[compiler-rt] b114940 - [builtins] Drop -fnested-functions flag from tests

Alex Richardson via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 17:20:20 PDT 2023


Author: Alex Richardson
Date: 2023-07-24T17:19:11-07:00
New Revision: b1149400122be1a9c713f3c31674a4f9b765c2d4

URL: https://github.com/llvm/llvm-project/commit/b1149400122be1a9c713f3c31674a4f9b765c2d4
DIFF: https://github.com/llvm/llvm-project/commit/b1149400122be1a9c713f3c31674a4f9b765c2d4.diff

LOG: [builtins] Drop -fnested-functions flag from tests

This flag does nothing for clang and is apparently not supported by GCC:
aarch64-linux-gnu-gcc: error: unrecognized command-line option '-fnested-functions'; did you mean '-Wunused-function'?
It looks like it was maybe supported by Apple GCC, but that is no longer
a supported compiler.

Differential Revision: https://reviews.llvm.org/D153819

Added: 
    

Modified: 
    compiler-rt/test/builtins/Unit/test
    compiler-rt/test/builtins/Unit/trampoline_setup_test.c

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/builtins/Unit/test b/compiler-rt/test/builtins/Unit/test
index e2a39a92ed2f98..e0683790c225cd 100755
--- a/compiler-rt/test/builtins/Unit/test
+++ b/compiler-rt/test/builtins/Unit/test
@@ -33,11 +33,6 @@ for ARCH in $ARCHS; do
       EXTRA="-fexceptions gcc_personality_test_helper.cxx -lstdc++ /usr/lib/libgcc_s.1.dylib"
       # the libgcc_s.1.dylib use at the end is a hack until libSystem contains _Unwind_Resume
     fi
-    if test $FILE = trampoline_setup_test.c
-    then
-      # this test requires an extra compiler option
-      EXTRA="-fnested-functions"
-    fi
     if test "$REMOTE" = "1"
     then 
       if gcc $CFLAGS $FILE ../../darwin_fat/Release/libcompiler_rt.a $LIBS $EXTRA -o ./remote/$FILE.exe

diff  --git a/compiler-rt/test/builtins/Unit/trampoline_setup_test.c b/compiler-rt/test/builtins/Unit/trampoline_setup_test.c
index 48341096b1ea58..da115fe7642718 100644
--- a/compiler-rt/test/builtins/Unit/trampoline_setup_test.c
+++ b/compiler-rt/test/builtins/Unit/trampoline_setup_test.c
@@ -1,4 +1,4 @@
-// RUN: %clang_builtins %s %librt -fnested-functions -o %t && %run %t
+// RUN: %clang_builtins %s %librt -o %t && %run %t
 // REQUIRES: librt_has_trampoline_setup
 
 #include <stdio.h>


        


More information about the llvm-commits mailing list