[PATCH] D152973: Reland "[gold] Add preliminary FatLTO support to the Gold plugin""

Mon Jul 24 14:36:46 PDT 2023

paulkirth added a comment.

In D152973#4529666 <https://reviews.llvm.org/D152973#4529666>, @MaskRay wrote:

> If `-ffat-lto-objects` doesn't need to go to the LLVM 17.0.0 release, we can do a soft transition:

Given that Rust pins the LLVM revision to a stable release I think it may be good to get it into Clang 17. Doubly so, since it seems to me that they already have a version of FatLTO, and would benefit from using the FatLTO pipeline.

> - Keep the LLVM and Clang parts in the `release/17.x` branch
> - Revert the Clang Driver `-ffat-lto-objects` change in `release/17.x` so that Clang 17 still doesn't support `-ffat-lto-objects`.
> - Give some time for @peter.smith and https://github.com/rust-lang/rust/ to migrate to `.llvm.lto` . I am not familiar with rust-lang/rust, but it seems that @alexcrichton is involved in some changes. Note, giving some time for the downstream should be considered a courtesy, not a norm.

Thanks for the suggestion. If we're not trying to make the next release, this sounds reasonable to me, though I am curious to hear what others think, too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152973/new/

https://reviews.llvm.org/D152973