[PATCH] D150388: [CodeGen]Allow targets to use target specific COPY instructions for live range splitting
    Matt Arsenault via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Jul 24 13:18:36 PDT 2023
    
    
  
arsenm added a comment.
In D150388#4529445 <https://reviews.llvm.org/D150388#4529445>, @arsenm wrote:
> In D150388#4529268 <https://reviews.llvm.org/D150388#4529268>, @vitalybuka wrote:
>
>> So if we have not fix, just discussion, should we revert? Even if it's preexisted unknown bug, I don't think it's appropriate to keep regression in existing functionality, for sake of fixing previously broken or missing functionally. 
>> Is it possible to workaround/revert some change with "if (x86) do old way" ?
>
> Try https://reviews.llvm.org/D156164 as a workaround. The high-bits-must-be-zero invariant disappears somewhere in the coalescer, this just hacks the resulting broken mov such that it hides the problem as it was before
Much better, probably real fix incoming
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150388/new/
https://reviews.llvm.org/D150388
    
    
More information about the llvm-commits
mailing list